Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify documentation for search paths #73818

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Simplify documentation for search paths #73818

merged 3 commits into from
Mar 23, 2022

Conversation

regendo
Copy link
Contributor

@regendo regendo commented Mar 8, 2021

SUMMARY

I found this information incredibly hard to read and understand. I tried my best to make it easier to read but I don't actually know how this works - if I knew how it worked, I wouldn't have searched for this documentation in the first place. So really this is just my best attempt at interpreting and translating the information that was already here.

If you know better, please do point out any mistakes I made. I'll be happy to rewrite it.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 8, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 23, 2021
@ansibot ansibot added the docs_only All changes are to files within the docs/docsite/ directory label Mar 31, 2021
@samccann
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 24, 2021
@samccann
Copy link
Contributor

@bcoca - is this PR correct now?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 2, 2021
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 18, 2021
@samccann
Copy link
Contributor

Hi @regendo - sorry for the extended delay on this Ansible docs PR. Can you rebase and we'll try to get this reviewed and merged?

@samccann samccann added the needs_info This issue requires further information. Please answer any outstanding questions. label Mar 17, 2022
I found this information incredibly hard to read and understand. I tried my best to make it easier to read but I don't actually know how this works - if I knew how it worked, I wouldn't have searched for this documentation in the first place. So really this is just my best attempt at interpreting and translating the information that was already here.

If you know better, please do point out any mistakes I made. I'll be happy to rewrite it.

- Docs Pull Request

+label: docsite_pr
@regendo
Copy link
Contributor Author

regendo commented Mar 21, 2022

Hi @samccann ! Fortunately not much has changed in this file since I opened the PR so the rebase was easy. Do you want the commits like this or should I have squashed them?

@ansibot ansibot removed needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 21, 2022
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Mar 21, 2022
@samccann samccann merged commit 8a86fa6 into ansible:devel Mar 23, 2022
@samccann
Copy link
Contributor

Thanks @regendo for pushing this Ansible docs PR along! We talk about Ansible documentation on maxtrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our ansible/community#643 - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@regendo regendo deleted the patch-1 branch March 25, 2022 10:49
@ansible ansible locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants