Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-doc: remove manual formatting #78668

Merged
merged 11 commits into from
Sep 8, 2022
Merged

ansible-doc: remove manual formatting #78668

merged 11 commits into from
Sep 8, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Updated version of #78561.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-doc

@felixfontein felixfontein marked this pull request as draft August 30, 2022 18:18
@felixfontein felixfontein mentioned this pull request Aug 30, 2022
Closed
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.14 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 30, 2022
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Aug 30, 2022
@felixfontein felixfontein marked this pull request as ready for review August 30, 2022 19:28
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Aug 30, 2022
ssbarnea
ssbarnea approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@webknjaz webknjaz requested a review from bcoca August 31, 2022 10:00
sivel
sivel reviewed Aug 31, 2022
View reviewed changes
lib/ansible/cli/doc.py Outdated Show resolved Hide resolved
sivel
sivel reviewed Aug 31, 2022
View reviewed changes
lib/ansible/cli/doc.py Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Aug 31, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 31, 2022
@webknjaz
Copy link
Member

webknjaz commented Sep 1, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bcoca
Copy link
Member

bcoca commented Sep 1, 2022

lgtm

bcoca
bcoca requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvmd

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 1, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 1, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2022
@mkrizek mkrizek mentioned this pull request Sep 6, 2022
Closed
@bcoca bcoca merged commit fa093d8 into ansible:devel Sep 8, 2022
@felixfontein felixfontein deleted the bcoca-remove-manual-formatting branch September 8, 2022 20:09
@felixfontein
Copy link
Contributor Author

@bcoca thanks for your work on this!
@ssbarnea @sivel @bcoca thanks for reviewing and merging!

@samccann samccann mentioned this pull request Sep 13, 2022
Closed
@ansible ansible locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel left review comments

@bcoca bcoca bcoca approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@felixfontein @webknjaz @bcoca @sivel @ssbarnea @mkrizek @ansibot