Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OS X 10.10 DP3. #8171

Merged
merged 2 commits into from
Jul 28, 2014
Merged

Support for OS X 10.10 DP3. #8171

merged 2 commits into from
Jul 28, 2014

Conversation

jbenden
Copy link
Contributor

@jbenden jbenden commented Jul 16, 2014

The attached commit fixes two known problems with Yosemite 10.10 OS X.

@mpdehaan
Copy link
Contributor

Appreciate the additions.

May I ask that you share information about what the known problems were? (Errors? Incorrect values?)

Also, what behaviors exist on prior versions with this change.

Thanks for elaboration.

@jbenden
Copy link
Contributor Author

jbenden commented Jul 17, 2014

For some reason, the general reading of sysctl -a fails to read the two properties in question under OS X 10.10. They are simply missing from the output. However, directly querying them works as required. This is what the proposed patch changes.

Because the same variables are read under any version of OS X, this change will not break previous versions.

@ericduran
Copy link

Quick FYI: I just tested the patch on 10.10 & it fixed the issue for me.

@mpdehaan
Copy link
Contributor

This now contains a change in the memfree math. Is this saying memfree was wrong in all previous OS X versions as well or does this change need to be OS specific?

(In general, it's a good idea to keep these kinds of changes on seperate branches and therefore as seperate branch submissions, so one thing doesn't hold up another).

In interest of not having OS X have fact gathering issues, I'm going to merge this regardless.

Thanks!

mpdehaan added a commit that referenced this pull request Jul 28, 2014
Support for OS X 10.10 DP3.
@mpdehaan mpdehaan merged commit 30e6a65 into ansible:devel Jul 28, 2014
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants