Replace use of boto with boto3 in awx venv (and modify its use getting region listing)

[wenottingham]

ISSUE TYPE

• Feature Idea

COMPONENT NAME

• API

SUMMARY

See #171

When that lands, and we start using the boto3 aws_ec2 inventory plugin, awx/main/models/inventory.py:get_ec2_region_choices should be updated to properly get regions from boto3 (and we can drop boto from the awx environment).

ENVIRONMENT

• AWX version: current

ADDITIONAL INFORMATION

[ryanpetrello]

👀 @AlanCoding

[AlanCoding]

It looks like we can at least close #2934 as a duplicate.

We do have boto in our main requirements, which is used for the sole purpose of getting ec2 requirements.

awx/requirements/requirements.in

Line 6 in aaeb2d6

boto==2.47.0

properly get regions from boto3 (and we can drop boto from the awx environment).

Is this saying that we replace boto in the awx requirements with boto3?

[wenottingham]

We'd need to rewrite the code that gets regions. AIUI the boto3 API is not the same.

[AlanCoding]

I changed the title of the issue to reflect this conversation, let me know if I do not have this right.

[deepy]

With boto 2.46.0 there's a BOTO_USE_ENDPOINT_HEURISTICS setting which might be worth looking at before this.

[ryanpetrello]

@chrismeyersfsu similar to #8021 (comment), is this something that should just work now that we've moved to a model where users can define explicit regions themselves?

[AlanCoding]

With the inventory plugin config changes, we removed the region listing. That means we're not using the boto library to produce the region listing. As far as I can see, we're not using boto anywhere else, but it's still in the requirements.

awx/requirements/requirements.in

Line 5 in cd8c74e

boto # replacement candidate https://github.com/ansible/awx/issues/2115

So we may be able to remove this library with no consequence.

Let me be clear that the Ansible venv certainly needs boto for inventory imports. That will have to wait a little longer to be removed from Ansible requirements, as it is migrated upstream ansible-collections/amazon.aws#125, where it will co-exist with boto3, so.. do whatever you want with it there.

[kdelee]

aws inventory testing still passing, going to close this as verified by regression tests