Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add/Edit workflow node to allow always to be used in conjunction with success and failure #2288

Closed
mabashian opened this issue Sep 20, 2018 · 0 comments
Assignees

Comments

@mabashian
Copy link
Member

ISSUE TYPE
  • Feature Task
COMPONENT NAME
  • UI
SUMMARY

link #2255

This issue tracks the UI work needed to support #2255. Currently there are restrictions placed on the edge type of a node based on the edge types of it's siblings. For example, when adding a new node if the parent of the new node has other children with an edge type of always then the new node's edge type is current restricted to always. The same is true for the combination of success/failure. In the previous example, if the children had an edge type of success then the new node's edge type would currently be restricted to success or failure. The work associated with this issue will remove that restriction from new/existing nodes. The user will now be able to select any of the three edge types regardless of the edge type(s) of it's siblings.

This is what the RUN (edge type) option should always look like (exception below):
screen shot 2018-09-20 at 9 25 29 am
I've outlined what the edge type restrictions currently look like. After this work is completed, all three options (always/success/failure) should be present:
screen shot 2018-09-20 at 9 26 15 am
screen shot 2018-09-20 at 9 25 55 am

The one exception to this rule is root nodes. These nodes are displayed as children of the start button and their edge type is always always:

screen shot 2018-09-20 at 9 24 59 am

Acceptance Criteria:

  1. As a user, I can create and edit a node with the WF visualizer using all three edge types, so I can create concise and manageable workflows
  2. Tests pass (e2e)
    • A test should be written that confirms that the edge type on a root node is always always
    • A test should be written that confirms that S/F/A can be selected when adding a node with no siblings
    • A test should be written that confirms that S/F/A can be selected when adding a node with a sibling
    • A test should be written that confirms that S/F/A can be selected when editing a node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants