Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edge conflict logic from delete workflow node #2289

Closed
mabashian opened this issue Sep 20, 2018 · 0 comments
Closed

Remove edge conflict logic from delete workflow node #2289

mabashian opened this issue Sep 20, 2018 · 0 comments
Assignees

Comments

@mabashian
Copy link
Member

ISSUE TYPE
  • Feature Task
COMPONENT NAME
  • UI
SUMMARY

link #2255

This issue tracks the UI work needed to support #2255. When a user deletes a workflow node, we roll the rest of the branch back into the vacated spot left by the deleted node. When this happens, there's a chance that sibling edge types could break our rule of mixing always and success/failure edge types.

Example, if we delete this node:
screen shot 2018-09-20 at 9 43 12 am

Then we now have sibling nodes (one with always and one with success). This currently results in what we refer to as an edge conflict:

screen shot 2018-09-20 at 9 44 36 am

#2255 removes this restriction so the UI can remove the notion of an edge conflict. In the above example, after deleting the node there should be no "edge conflict" indicators and the save button should be enabled.

Acceptance Criteria:

  1. As a user, I can delete a node with the WF visualizer without causing an edge conflict so I can create manageable workflows
  2. Tests pass (e2e)
    • A test should be written that confirms that deleting a node does not result in an edge conflict and the user can edit the new child node and select any of S/F/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants