-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO login redirect override URL is not working #9115
Comments
@mabashian @jakemcdermott do you have an issue to track adding this support back into the new UI (if not, we can use this one)? |
👋 Hello, @gmtime I couldn't reproduce this. I see the redirect override field and can update its value: I used an admin user on a fresh install. Are there any additional set up steps I should do? If you can still reproduce the bug, would you be able to post a screenshot? |
@jakemcdermott I think they're suggesting that after successful login, the browser is not redirecting to this URL i.e., |
BTW, that's an upgrade from 15.0.1 to 16.0.0 - I did not try with the fresh install. |
Regarding Login and SSO, it would be great it we could customize SSO label and icon (e.g. "MyCompany SSO Users Log In Here") |
@ryanpetrello, @jakemcdermott, just a small correction: it's not that after successful login the browser is not redirecting, it's the login process itself. Before 16.0.0, with Login Redirect Override URL users were immediately redirected to SSO page to login - now we always get AWX login page. Clicking on SAML icon will execute SSO process correctly and users will login correctly - that works - but transparent SSO login does not work any more. |
This smells like ui-specific issue to me so I'm going to remove the api label. |
AWX 17.1.0 has the same issue with Login redirect override URL. And I have raised another issue for the Login icons #9554 |
Additional notes on expected behavior - The auto-redirect should only kick-in when there is exactly one SSO provider configured. If there is more than one then we don't redirect |
Fixes SSO Redirect SUMMARY This fixes #9115 by simply checking if there is a redirect url in and then replacing it with the existing url in history, navigating the user to the correct login url. ISSUE TYPE Bugfix Pull Request COMPONENT NAME UI AWX VERSION ADDITIONAL INFORMATION Reviewed-by: Jake McDermott <yo@jakemcdermott.me> Reviewed-by: Alex Corey <Alex.swansboro@gmail.com>
ISSUE TYPE
SUMMARY
After upgrading to 16.0.0, SSO Login redirect override URL is no longer working.
"Settings->System->Miscellaneous System settings->Details" correctly shows "Login redirect override URL" setting (for example: /sso/login/saml/?idp=MYIDP), but editing is not possible and users are no longer automatically redirected.
ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
ADDITIONAL INFORMATION
Also, would it be possible, when using SSO, to have SSL (SAML) icon and text dominantly displayed inside the login box? Currently, there is no text and the icon (UserCircleIcon) is too small. For SSO (SAML) users it is difficult to figure out that in order to login one needs to click on that tiny-microscopic-icon.
The text was updated successfully, but these errors were encountered: