Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO login redirect override URL is not working #9115

Closed
gmtime opened this issue Jan 20, 2021 · 10 comments · Fixed by #9943
Closed

SSO login redirect override URL is not working #9115

gmtime opened this issue Jan 20, 2021 · 10 comments · Fixed by #9943

Comments

@gmtime
Copy link

gmtime commented Jan 20, 2021

ISSUE TYPE
  • Bug Report
SUMMARY

After upgrading to 16.0.0, SSO Login redirect override URL is no longer working.

"Settings->System->Miscellaneous System settings->Details" correctly shows "Login redirect override URL" setting (for example: /sso/login/saml/?idp=MYIDP), but editing is not possible and users are no longer automatically redirected.

ENVIRONMENT
  • AWX version: 16.0.0
  • AWX install method: docker on linux
  • Operating System: any
  • Web Browser: any
STEPS TO REPRODUCE
  1. go to Settings->System->Miscellaneous System settings->Details
  2. click on Edit
  3. "Login redirect override URL" edit field is missing
EXPECTED RESULTS
  1. go to Settings->System->Miscellaneous System settings->Details
  2. click on Edit
  3. enter data for "Login redirect override URL"
  4. users automatically redirected to SSO
ACTUAL RESULTS
  1. it's not possible to add/edit SSO override URL ("Login redirect override URL")
  2. users are not redirected to SSO
ADDITIONAL INFORMATION

Also, would it be possible, when using SSO, to have SSL (SAML) icon and text dominantly displayed inside the login box? Currently, there is no text and the icon (UserCircleIcon) is too small. For SSO (SAML) users it is difficult to figure out that in order to login one needs to click on that tiny-microscopic-icon.

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Jan 20, 2021

@mabashian @jakemcdermott do you have an issue to track adding this support back into the new UI (if not, we can use this one)?

#1886
#5479

@jakemcdermott
Copy link
Contributor

jakemcdermott commented Jan 20, 2021

👋 Hello, @gmtime I couldn't reproduce this. I see the redirect override field and can update its value:

login-redirect-url

I used an admin user on a fresh install. Are there any additional set up steps I should do? If you can still reproduce the bug, would you be able to post a screenshot?

@ryanpetrello
Copy link
Contributor

@jakemcdermott I think they're suggesting that after successful login, the browser is not redirecting to this URL i.e.,

https://github.com/ansible/awx/pull/5479/files#diff-82df1a8c96813927cf31345d61c02a0f7532cd8880d699ee7b23e041afb0259dR388

@gmtime
Copy link
Author

gmtime commented Jan 20, 2021

Correct, it's not redirecting. Also, I don't seem to be able to edit the redirect URL (see screenshots). There is also a question of having really small SSO icon (hard to find).
Screen Shot 2021-01-20 at 17 51 03
Screen Shot 2021-01-20 at 17 51 27
Screen Shot 2021-01-20 at 17 49 50

@gmtime
Copy link
Author

gmtime commented Jan 20, 2021

BTW, that's an upgrade from 15.0.1 to 16.0.0 - I did not try with the fresh install.

@gmtime
Copy link
Author

gmtime commented Jan 20, 2021

Regarding Login and SSO, it would be great it we could customize SSO label and icon (e.g. "MyCompany SSO Users Log In Here")

@gmtime
Copy link
Author

gmtime commented Jan 21, 2021

@jakemcdermott I think they're suggesting that after successful login, the browser is not redirecting to this URL i.e.,

https://github.com/ansible/awx/pull/5479/files#diff-82df1a8c96813927cf31345d61c02a0f7532cd8880d699ee7b23e041afb0259dR388

@ryanpetrello, @jakemcdermott, just a small correction: it's not that after successful login the browser is not redirecting, it's the login process itself.

Before 16.0.0, with Login Redirect Override URL users were immediately redirected to SSO page to login - now we always get AWX login page. Clicking on SAML icon will execute SSO process correctly and users will login correctly - that works - but transparent SSO login does not work any more.

@mabashian
Copy link
Member

This smells like ui-specific issue to me so I'm going to remove the api label.

@balonik
Copy link

balonik commented Mar 11, 2021

AWX 17.1.0 has the same issue with Login redirect override URL.

And I have raised another issue for the Login icons #9554

@AlexSCorey AlexSCorey self-assigned this Apr 5, 2021
@jakemcdermott
Copy link
Contributor

Additional notes on expected behavior - The auto-redirect should only kick-in when there is exactly one SSO provider configured. If there is more than one then we don't redirect

softwarefactory-project-zuul bot added a commit that referenced this issue Apr 22, 2021
Fixes SSO Redirect

SUMMARY
This fixes #9115 by simply checking if there is a redirect url in and then replacing it with the existing url in history, navigating the user to the correct login url.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

UI

AWX VERSION
ADDITIONAL INFORMATION

Reviewed-by: Jake McDermott <yo@jakemcdermott.me>
Reviewed-by: Alex Corey <Alex.swansboro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants