When using awx_official and a remote host; synchronize task wil fail

[mhogerheijde]

Summary

During install; when using the official branding – by setting awx_official=true – there will be a task making use of the module synchronize. When also running the playbook against a remote host; this taks will fail, where a password is asked to authenticate against the remote machine. The copy should – however – take place on the local machine only.

Environment

• AWX version: 1.0.0.294 / commit id 2fb9b6c
• Ansible version: 2.3.2.0
• Operating System: Ubuntu 17.04
• Web Browser: N/A

Steps To Reproduce:

1. Check out both https://github.com/ansible/awx.git and https://github.com/ansible/awx-logos.git
2. Change the awx/installer/inventory file:
   set awx_official=true
   change localhost ansible_connection=local into a remote host; using the correct settings for user and privilege elevetion method.
   awx.local ansible_user=ubuntu ansible_become=yes ansible_become_method=sudo
   to create a temp host, one can use this Vagrantfile; place it in a folder and run vagrant up. One needs to have vagrant and Virtualbox installed. Change your hosts file to contain the ip pointing to awx.local.
3. Go to the installer directory and run ansible-playbook -i inventory install.yml

Expected Results:

The playbook to finish installing AWX, without asking me for a password during the play.

Actual Results:

During task Copy logos for inclusion in sdist, a password is requested to authenticate the local user against the remote machine.

TASK [image_build : Copy logos for inclusion in sdist] *************************
local-user@awx.local's password:

Additional Information:

This thread on StackOverflow also speaks about the synchronize module not playing nice with delegate_to: localhost. The clue seems to be that this will only work when the inventory contains localhost and not a remote host.

[tima]

I'm pretty sure this is a core engine issue that's already been resolved and will be released in v2.4: ansible/ansible#23991

[matburt]

Implemented in #267