Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awxkit random_title setting non_ascii to False #10856

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

tiagodread
Copy link
Contributor

@tiagodread tiagodread commented Aug 10, 2021

SUMMARY

Working on Bumping Cypress version to latest, I realized that there is an issue with cy.intercept() and special chars.

I'm updating random_title and setting non_ascii default to False, based on the comment, this was because a bug related to selenium webdriver, however, Cypress works in a different way and this is not necessary.

Copy link
Member

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to finish this review. This will solve your problem and is the simplest solution, I wonder though if it would be possible to keep the default True as that does provide some coverage in other use cases than your own. But maybe we could have a setting or an env var that overrides it. like

def random_title(num_words=2, non_ascii=True):
    if os.getenv('AWXKIT_FORCE_ONLY_ASCII', False):
        non_ascii=False

@tiagodread tiagodread merged commit ebe5fff into ansible:devel Aug 11, 2021
@tiagodread tiagodread deleted the awxkit branch August 11, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants