Fix TypeError when running a command on a host in a smart inventory #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixocio
force-pushed
the
ui_issue_11611
branch
from
4c8a8ab
to
06dc72c
Compare
nixocio
force-pushed
the
ui_issue_11611
branch
from
06dc72c
to
b82d70d
Compare
Fix TypeError when running a command on a host in a smart inventory See: ansible#11611
nixocio
force-pushed
the
ui_issue_11611
branch
from
b82d70d
to
92eb26a
Compare
marshmalien
approved these changes
Feb 17, 2022
| @@ -91,6 +99,7 @@ function SmartInventoryHostList({ inventory }) { | |||
| adHocItems={selected} | |||
| hasListItems={count > 0} | |||
| onLaunchLoading={setIsAdHocLaunchLoading} | |||
| moduleOptions={moduleOptions} | |||
There was a problem hiding this comment.
👍 Verified that adding this prop resolves the issue. Thanks for defining the PropTypes in AdHocCommands. Nice work!
|
I triggered the e2e tests. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
InnocentK
approved these changes
Feb 21, 2022
AlexSCorey
pushed a commit
to AlexSCorey/awx
that referenced
this pull request
Feb 22, 2022
…nsible#11768) Fix TypeError when running a command on a host in a smart inventory See: ansible#11611
AlexSCorey
pushed a commit
to AlexSCorey/awx
that referenced
this pull request
Feb 23, 2022
…nsible#11768) Fix TypeError when running a command on a host in a smart inventory See: ansible#11611
slemrmartin
pushed a commit
to slemrmartin/awx
that referenced
this pull request
Mar 30, 2022
…nsible#11768) Fix TypeError when running a command on a host in a smart inventory See: ansible#11611
slemrmartin
pushed a commit
to slemrmartin/awx
that referenced
this pull request
Mar 30, 2022
…nsible#11768) Fix TypeError when running a command on a host in a smart inventory See: ansible#11611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeError when running a command on a host in a smart inventory
See: #11611