Remove deprecated field update_on_project_update

[fosterseth]

SUMMARY

remove deprecated fields update_on_project_update and scm_last_revision for InventorySource
related #12206

todo: fix up / remove QA tests

ISSUE TYPE

• New or Enhanced Feature

COMPONENT NAME

• API

AWX VERSION

awx: 21.0.1.dev219+g0df3c655b9

[AlanCoding]

This is the only change that might be somewhat consequential to the user. I would probably put a warning level log here. This is also a big item for the release notes.

[AlanCoding]

We may be able to remove the SCM launch type

awx/awx/main/models/unified_jobs.py

Line 536 in 0df3c65

('scm', _('SCM Update')), # Job was created as an Inventory SCM sync.

If not, I would advocate that we change it to deprecated. Inventory updates from before the migration could still validly have this status.

[AlanCoding]

Even if we do nothing on that launch_type option, we can still purge references to the "scm" value. In particular, these lines in the RunInventorySource model are complementary to logic in the _update_dependent_inventories which is already being deleted.

awx/awx/main/tasks/jobs.py

Lines 1604 to 1606 in 0df3c65

	elif inventory_update.source == 'scm' and inventory_update.launch_type == 'scm' and source_project:
	# This follows update, not sync, so make copy here
	RunProjectUpdate.make_local_copy(source_project, private_data_dir)

[AlanCoding]

A more minor deletion would be here:

awx/awx/main/models/inventory.py

Line 1307 in a3e2931

if self.launch_type != 'scm' and self.source_project_update:

The condition self.launch_type != 'scm' should always resolve to true after this. So only checking if self.source_project_update_id: would be the most efficient.

[AlanCoding]

This looks like it may need something added back in. Jobs have an scm_revision field to track which revision it ran. We may want to add back in a similar field for inventory updates.

[fosterseth]

would it be better to have InventorySource.scm_revision to be consistent with Job.scm_revision?

[AlanCoding]

I'm hitting some similar questions in #12356. Jobs and inventory updates logically should have a multitude of things in common (like this) but it was never fully thought out. My short answer is "yes", it should be consistent, but the broader UI impact and things probably need to get some thought.