add state to awx license module #12397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:awx_collection
sean-m-sullivan
force-pushed
the
awx_license_delete
branch
2 times, most recently
from
0e0bb23
to
d6d0a47
Compare
sean-m-sullivan
force-pushed
the
awx_license_delete
branch
from
d6d0a47
to
7bcceb7
Compare
john-westcott-iv
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The API allows for removal of license, and the collections should reflect what the API allows. In that vein, adding a state to the license module. While the manifest option is no longer required, it should still fail if not supplied when state is present.
This issue was raised in this blog.
English translation link
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
Testing was not added, as I was not sure how that would effect the testing environment. Can add it if requested. It has been tested.