Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where the initial form value of verbosity isn't respected #12650

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

matburt
Copy link
Member

@matburt matburt commented Aug 12, 2022

SUMMARY

It looks like ef8d4e7 from PR #12378 removed this reference to .value. I don't fully understand the implications of the commit but putting this value reference back in allows the form to work in it's default state again. This would seem to fix #12575

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • UI
AWX VERSION
awx: 21.4.1.dev50+g1ae1da3f9c
ADDITIONAL INFORMATION

This is currently broken on the latest AWX release


@mabashian
Copy link
Member

Fix looks good, I'll address the test failure

@mabashian mabashian changed the title Fix a bug where the form value of verbosity isn't respect Fix a bug where the initial form value of verbosity isn't respected Aug 12, 2022
@mabashian mabashian changed the title Fix a bug where the initial form value of verbosity isn't respected Fixed a bug where the initial form value of verbosity isn't respected Aug 12, 2022
@mabashian
Copy link
Member

Under the hood, verbosity is tracked by an integer. 0 corresponds to 0 (Normal), 1 corresponds to 1 (Verbose) and so on...

For adhoc jobs we always default to 0 (Normal). @matburt's original fix worked because VERBOSITY()[0].value was evaluating as undefined (same as 0) but the unit tests caught that. Since we know the default initial value is 0 lets just set it to 0.

@akus062381 akus062381 self-assigned this Aug 15, 2022
@akus062381 akus062381 merged commit 67c9e1a into ansible:devel Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to run an adhoc command results in error
3 participants