use exceptions for job cancel and failure #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwitzel3
approved these changes
Sep 8, 2017
matburt
approved these changes
Sep 8, 2017
mabashian
pushed a commit
to mabashian/awx
that referenced
this pull request
Jun 28, 2019
Update build system
elyezer
pushed a commit
to elyezer/awx
that referenced
this pull request
Oct 13, 2020
9 tasks
kdelee
pushed a commit
that referenced
this pull request
Mar 8, 2023
check label permission and fix lint (#13) * set created by and launch type correctly This makes "launched_by" get computed right in the tests. Mysteriously this seemed to work from API browser, but this seems more correct to have it work this way, and makes tests actually work. For "manual" launch types the attribute used to populate "launched_by" is "created_by". And we already have "is_bulk_job" to indicate that the job is a bulk job. So lets just use this. * check label is in an organization you can read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like that we were providing a full traceback with job canceling and errors. It's not our error, and the line numbers provide no value anyway.
Signed-off-by: Alan Rominger arominge@redhat.com