Don't use English for string comparisons

[dmzoneill]

SUMMARY

This work is to remove string validation using comparisons of English literals for comparison.
This replaces validation with error/op codes as a universal approach to validation and comparison

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• API

AWX VERSION

all

[jbradberry]

You've lost the raise in this exception handler.

[dmzoneill]

added raise on 805

[jbradberry]

FYI, the "did not affect any rows" message is coming from Django instead of the db in this case: https://github.com/django/django/blob/eff21d8e7a1cb297aedf1c702668b590a1b618f3/django/db/models/base.py#L1107

It's that one in particular, since i.update_computed_fields() makes use of .save(update_fields=...).

You are correct that in this case the exception won't get a sqlstate, so this flow of logic looks ok to me.

[jbradberry]

While I would expect that this exception block would always get a sqlstate, if we are coding defensively the raise should be outside of the if block, just in case that isn't so.

[jbradberry]

This looks good, my only recommendation now is to probably code more defensively around the raise in utils/common.py.

[jbradberry]

Per offline conversation, I do not believe that this logging will fire off.

• Inventory.update_computed_fields does not seem to return a value (unless I missed it)
  • edit: I've now commented on your changes that attempted to add that
• Django's internals raise the "did not affect any rows" error, not any database backend (ref: https://github.com/django/django/blob/eff21d8e7a1cb297aedf1c702668b590a1b618f3/django/db/models/base.py#L1107). Therefore we'll get a DatabaseError anyway, bypassing this line, and that exception will not have a sqlstate attached.

[jbradberry]

New comment.

[jbradberry]

I oppose this change for the following reasons:

• making changes here has crept out of the scope of this PR
• the bulk_update is not the only save occurring in this method, so returning only its row count isn't very idiomatic
• this does absolutely nothing to address the fact that iobj.save(update_fields=computed_fields.keys()) is going to raise the DatabaseError("Save with update_fields did not affect any rows.") exception in the case we care about

needs re-review

[Klaas-]

possible regression because of this change #15016