Update test so that DAB change can merge #15222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
May 23, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Really minor change to unblock merging DAB change at ansible/django-ansible-base#412
That change is adding another configurable restriction to the RBAC assignments. This one very specifically says "a team can not be an organization member".
The prior condition of
ANSIBLE_BASE_ALLOW_TEAM_ORG_ADMINsaid "a team can not become a parent of teams via an organization-level role", which I admit is confusing, but still accomplished its stated objective in a very confusing way.In any case, it is fully intended to have both conditions, and for both to be disallowed by default. Being an org member because of the teams you're a member of would be a communication challenge. The test has to disable both, because it does the thing we don't really want people to do.
ISSUE TYPE
COMPONENT NAME