Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin apache-libcloud to a version that doesn't use PyCrypto #3466

Conversation

ryanpetrello
Copy link
Contributor

@ryanpetrello ryanpetrello commented Mar 21, 2019

once a new version lands on PyPI, we'll pin to it

@AlanCoding
Copy link
Member

Just to put it in text, expected version is probably 2.4.1.

@ryanpetrello
Copy link
Contributor Author

Yep, whenever 2.4.1 comes out (or 2.5.0, whatever's first), that's the minimum version we want.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ryanpetrello
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@ryanpetrello
Copy link
Contributor Author

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

once a new version lands on PyPI, we'll pin to _it_
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ryanpetrello
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@matburt
Copy link
Member

matburt commented Mar 21, 2019

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a562994 into ansible:devel Mar 21, 2019
@AlanCoding
Copy link
Member

Something isn't adding up here. Putting something in requirements_ansible_git.txt doesn't do anything. Using the pip-compile instructions, it is expected that this line is added.

diff --git a/requirements/requirements_ansible.txt b/requirements/requirements_ansible.txt
index f784719888..f80806d9bf 100644
--- a/requirements/requirements_ansible.txt
+++ b/requirements/requirements_ansible.txt
@@ -4,10 +4,11 @@
 #
 #    pip-compile --output-file requirements/requirements_ansible.txt requirements/requirements_ansible.in
 #
-adal==0.5.0               # via msrestazure
-appdirs==1.4.3            # via openstacksdk, os-client-config
-applicationinsights==0.11.1  # via azure-cli-core
-argcomplete==1.9.4        # via azure-cli-core, knack
+git+https://github.com/ansible/libcloud@trunk#egg=apache-libcloud
+adal==1.2.1               # via msrestazure
+appdirs==1.4.3            # via openstacksdk
+applicationinsights==0.11.8  # via azure-cli-core
+argcomplete==1.9.5        # via azure-cli-core, knack
 asn1crypto==0.24.0        # via cryptography
 azure-cli-core==2.0.35
 azure-cli-nspkg==3.0.2

The 2.4.1 release that we're waiting on is still not available, so we're still stuck with this.

Should I add this in, or is the requirement being pulled some other way that I don't see? If we don't put it in, we need to call this out in the instructions.

@AlanCoding
Copy link
Member

Never mind, I guess we actually have not been maintaining this ever since

93dda55#diff-444e80f30bd2f1e25b779966c9621b9b

I'm going to be removing this part from the instructions @shanemcd @chrismeyersfsu let me know if I'm off base in any way here. I'll put up a PR with the specific action in a little bit.

@AlanCoding
Copy link
Member

Here is that PR #3682

@ryanpetrello ryanpetrello deleted the libcloud-minus-pycrypto branch April 16, 2019 14:10
ryanpetrello added a commit to ryanpetrello/awx that referenced this pull request Jun 4, 2019
ryanpetrello added a commit to ryanpetrello/awx that referenced this pull request Jun 4, 2019
sganesh999 pushed a commit to sganesh999/awx that referenced this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants