-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin apache-libcloud to a version that doesn't use PyCrypto #3466
pin apache-libcloud to a version that doesn't use PyCrypto #3466
Conversation
Just to put it in text, expected version is probably |
Yep, whenever 2.4.1 comes out (or 2.5.0, whatever's first), that's the minimum version we want. |
Build failed.
|
recheck |
9bfeccd
to
8b5dfdd
Compare
Build failed.
|
8b5dfdd
to
d301e79
Compare
Build succeeded.
|
Build succeeded (gate pipeline).
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
d301e79
to
e96e652
Compare
Build succeeded.
|
Build succeeded (gate pipeline).
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
regate |
Build succeeded (gate pipeline).
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
once a new version lands on PyPI, we'll pin to _it_
e96e652
to
b02d9ae
Compare
Build failed.
|
recheck |
Build succeeded.
|
regate |
Build succeeded (gate pipeline).
|
Something isn't adding up here. Putting something in diff --git a/requirements/requirements_ansible.txt b/requirements/requirements_ansible.txt
index f784719888..f80806d9bf 100644
--- a/requirements/requirements_ansible.txt
+++ b/requirements/requirements_ansible.txt
@@ -4,10 +4,11 @@
#
# pip-compile --output-file requirements/requirements_ansible.txt requirements/requirements_ansible.in
#
-adal==0.5.0 # via msrestazure
-appdirs==1.4.3 # via openstacksdk, os-client-config
-applicationinsights==0.11.1 # via azure-cli-core
-argcomplete==1.9.4 # via azure-cli-core, knack
+git+https://github.com/ansible/libcloud@trunk#egg=apache-libcloud
+adal==1.2.1 # via msrestazure
+appdirs==1.4.3 # via openstacksdk
+applicationinsights==0.11.8 # via azure-cli-core
+argcomplete==1.9.5 # via azure-cli-core, knack
asn1crypto==0.24.0 # via cryptography
azure-cli-core==2.0.35
azure-cli-nspkg==3.0.2 The 2.4.1 release that we're waiting on is still not available, so we're still stuck with this. Should I add this in, or is the requirement being pulled some other way that I don't see? If we don't put it in, we need to call this out in the instructions. |
Never mind, I guess we actually have not been maintaining this ever since 93dda55#diff-444e80f30bd2f1e25b779966c9621b9b I'm going to be removing this part from the instructions @shanemcd @chrismeyersfsu let me know if I'm off base in any way here. I'll put up a PR with the specific action in a little bit. |
Here is that PR #3682 |
once a new version lands on PyPI, we'll pin to it