Replace certifi with an alternate version #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
This version just uses the system cert store.
|
Build failed.
|
|
Build succeeded.
|
| @@ -0,0 +1 @@ | |||
| git+https://github.com/ansible/system-certifi.git@devel#egg=certifi | |||
There was a problem hiding this comment.
~ pip install git+https://github.com/ansible/system-certifi.git
Looking in links: file:///Users/ryan/.pip/wheelhouse
Collecting git+https://github.com/ansible/system-certifi.git
Cloning https://github.com/ansible/system-certifi.git to /tmp/pip-req-build-jtkhbv8y
Running command git clone -q https://github.com/ansible/system-certifi.git /tmp/pip-req-build-jtkhbv8y
Installing collected packages: certifi
Running setup.py install for certifi ... done
Successfully installed certifi-2038.12.31~/venvs/tmp-d9cf71ec804f569 python
Python 3.8.5 (default, Jul 20 2020, 00:00:00)
[GCC 10.1.1 20200507 (Red Hat 10.1.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import certifi
>>> certifi.where()
'/etc/pki/tls/certs/ca-bundle.crt'👍
ryanpetrello
approved these changes
Sep 28, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version just uses the system cert store.
Reimplementation of #8192.
Necessary but not 100% sufficient condition of #416. WIll make it better for many things.
ISSUE TYPE
COMPONENT NAME