Add system jobs interface w/ configurable data retention #9224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemcdermott
commented
Feb 3, 2021
awx/ui_next/src/screens/ManagementJob/ManagementJobList/ManagementJobList.jsx
Show resolved
Hide resolved
jakemcdermott
commented
Feb 3, 2021
|
Build succeeded.
|
jakemcdermott
requested review from
shanemcd,
ryanpetrello,
AlexSCorey,
keithjgrant,
marshmalien and
nixocio
jakemcdermott
commented
Feb 3, 2021
jakemcdermott
commented
Feb 4, 2021
awx/ui_next/src/screens/ManagementJob/ManagementJobList/LaunchManagementPrompt.jsx
Show resolved
Hide resolved
|
@jakemcdermott we had some difficulties getting an environment set up. Our only point of feedback so far is that it might make sense to get rid of advanced search from this view |
|
@jakemcdermott I took a look and it looks good. It sounds like you want to make a few more changes (table conversion and removing the launch prompt). Let me know when the dust has settled and I'll take another look. |
jakemcdermott
force-pushed
the
add-mgmt-jobs
branch
2 times, most recently
from
37e6660
to
c81c9fe
Compare
|
Build succeeded.
|
nixocio
reviewed
Feb 17, 2021
| import NotificationsMixin from '../mixins/Notifications.mixin'; | ||
| import SchedulesMixin from '../mixins/Schedules.mixin'; | ||
|
|
||
| const Mixins = SchedulesMixin(NotificationsMixin(Base)); |
|
Build succeeded.
|
jakemcdermott
requested review from
nixocio and
mabashian
and removed request for
ryanpetrello and
shanemcd
|
Build failed.
|
jakemcdermott
force-pushed
the
add-mgmt-jobs
branch
from
1839cc4
to
3af02ae
Compare
* Migate management jobs list to tables * Use cancel link variant for consistency with other prompts * Add basic test coverage for sysjobs * Remove select-all from mgmt jobs * Remove unneeded component variables * Fix missing schedule breadcrumb * Optimize data fetching with useCallback
Co-authored-by: Tiago Góes <tiago.goes2009@gmail.com>
jakemcdermott
force-pushed
the
add-mgmt-jobs
branch
from
3af02ae
to
218b978
Compare
@one-t I think this should be fixed now - Can you try it w/ the latest? |
|
Build succeeded.
|
one-t
approved these changes
Feb 24, 2021
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockups: https://tower-mockups.testing.ansible.com/patternfly/mgmt-jobs/mgmt-jobs
Related: #8488
SUMMARY