Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system jobs interface w/ configurable data retention #9224

Merged

Conversation

jakemcdermott
Copy link
Contributor

@jakemcdermott jakemcdermott commented Feb 3, 2021

Mockups: https://tower-mockups.testing.ansible.com/patternfly/mgmt-jobs/mgmt-jobs

Related: #8488

SUMMARY
  • Adds interface for management (system jobs)
  • Adds configurable data retention field on schedules view

Screenshot from 2021-02-03 17-00-43

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

awx/main/models/jobs.py Outdated Show resolved Hide resolved
@unlikelyzero unlikelyzero added the type:feature prioritized on a feature board label Feb 8, 2021
@unlikelyzero
Copy link

@jakemcdermott we had some difficulties getting an environment set up. Our only point of feedback so far is that it might make sense to get rid of advanced search from this view

@mabashian
Copy link
Member

@jakemcdermott I took a look and it looks good. It sounds like you want to make a few more changes (table conversion and removing the launch prompt). Let me know when the dust has settled and I'll take another look.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

import NotificationsMixin from '../mixins/Notifications.mixin';
import SchedulesMixin from '../mixins/Schedules.mixin';

const Mixins = SchedulesMixin(NotificationsMixin(Base));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

woahh

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jakemcdermott jakemcdermott requested review from nixocio and mabashian and removed request for ryanpetrello and shanemcd February 17, 2021 16:25
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jakemcdermott
Copy link
Contributor Author

jakemcdermott commented Feb 24, 2021

I found another issue- in the schedules tab, if you click an existing schedule, you'll get an error

@one-t I think this should be fixed now - Can you try it w/ the latest?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cb05b54 into ansible:devel Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui type:feature prioritized on a feature board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants