Properly tags Plural-able strings for translation, and removes unnecessary i18n #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@AlexSCorey can you run the visual tests and functional tests? |
keithjgrant
reviewed
Apr 13, 2021
| <span>{`: ${itemsUnableToDelete}`}</span> | ||
| </> | ||
| ) : ( | ||
| i18n._( |
There was a problem hiding this comment.
If usage of t is not going to completely remove i18n._( we will have 2 standards for translation syntax. It there any benefit in using one over the other?
There was a problem hiding this comment.
In most cases we will be able to remove withI18n() HOC and also i18n that is being injected into the components in favor of simply using t
nixocio
reviewed
Apr 15, 2021
| <Plural | ||
| value={selected.length} | ||
| one="This execution environment is currently being used by other resources. Are you sure you want to delete it?" | ||
| other="Deleting these execution environemnts could impact other resources that rely on them. Are you sure you want to delete anyway?" |
There was a problem hiding this comment.
Suggested change
| other="Deleting these execution environemnts could impact other resources that rely on them. Are you sure you want to delete anyway?" | |
| other="Deleting these execution environments could impact other resources that rely on them. Are you sure you want to delete anyway?" |
|
Build succeeded.
|
|
@AlexSCorey looks like this one is gonna need a rebase |
|
Build succeeded.
|
tiagodread
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
@AlexSCorey I'm facing the same problem in different places (dev or production build) like:
|
Build succeeded.
|
tiagodread
approved these changes
Apr 23, 2021
|
Build succeeded.
|
|
regate |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This resolves #9891.
It also begings the process of remove
i18n._(t string)in places in favor of this syntaxISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION