Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "wait_for_migrations" command #927

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Alex-Izquierdo
Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo commented Jun 4, 2024

aap-eda-manage wait_for_migrations -t 60
Replaces #925

@Alex-Izquierdo Alex-Izquierdo requested a review from a team as a code owner June 4, 2024 13:21
@Alex-Izquierdo Alex-Izquierdo changed the title feat: add "wair_for_migrations" command feat: add "wait_for_migrations" command Jun 4, 2024
@rooftopcellist
Copy link
Member

@Alex-Izquierdo I just tested this out with my branch and it works as expected, great idea with making this a manage command!

$ oc logs -f eda-activation-worker-8b57696cb-dwzjn -c wait-for-migrations
All migrations are applied.

In the scheduler init container, we see an info message about failing to get the service id, this is expected:

$ oc logs -f eda-scheduler-696588bdc-9njrm -c wait-for-migrations
2024-06-04 13:47:25,438 aap_eda.core.tasking INFO     Failed to get service id
All migrations are applied.

I confirmed that I don't see it in the actual scheduler container logs:

$ oc logs -f eda-scheduler-696588bdc-9njrm
2024-06-04 13:47:46,645 aap_eda.core.management.commands.scheduler INFO     No scheduled jobs. Skipping.
2024-06-04 13:47:46,645 aap_eda.core.management.commands.scheduler INFO     Adding periodic job "aap_eda.tasks.orchestrator.enqueue_monitor_rulebook_processes"
2024-06-04 13:47:46,648 aap_eda.core.management.commands.scheduler INFO     Adding periodic job "aap_eda.tasks.project.monitor_project_tasks"
2024-06-04 13:47:46,649 aap_eda.core.management.commands.scheduler INFO     No scheduled jobs. Skipping.
13:47:46 Registering birth
2024-06-04 13:47:46,650 rq_scheduler.scheduler INFO     Registering birth

@rooftopcellist rooftopcellist self-requested a review June 4, 2024 13:54
rooftopcellist
rooftopcellist previously approved these changes Jun 4, 2024
Signed-off-by: Alex <aizquier@redhat.com>
@Alex-Izquierdo Alex-Izquierdo merged commit d961f07 into ansible:main Jun 4, 2024
4 checks passed
@Alex-Izquierdo Alex-Izquierdo deleted the wait-for-cmd branch June 4, 2024 19:37
jshimkus-rh pushed a commit to jshimkus-rh/eda-server that referenced this pull request Jun 5, 2024
Signed-off-by: Alex <aizquier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants