-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "wait_for_migrations" command #927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Izquierdo
changed the title
feat: add "wair_for_migrations" command
feat: add "wait_for_migrations" command
Jun 4, 2024
Alex-Izquierdo
force-pushed
the
wait-for-cmd
branch
from
June 4, 2024 13:27
3d93be2
to
a832ba9
Compare
@Alex-Izquierdo I just tested this out with my branch and it works as expected, great idea with making this a manage command!
In the scheduler init container, we see an info message about failing to get the service id, this is expected:
I confirmed that I don't see it in the actual scheduler container logs:
|
rooftopcellist
previously approved these changes
Jun 4, 2024
Alex-Izquierdo
force-pushed
the
wait-for-cmd
branch
from
June 4, 2024 14:28
a832ba9
to
fc73f09
Compare
Signed-off-by: Alex <aizquier@redhat.com>
Alex-Izquierdo
force-pushed
the
wait-for-cmd
branch
from
June 4, 2024 14:30
fc73f09
to
a341d91
Compare
bzwei
approved these changes
Jun 4, 2024
hsong-rh
approved these changes
Jun 4, 2024
jshimkus-rh
pushed a commit
to jshimkus-rh/eda-server
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Alex <aizquier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aap-eda-manage wait_for_migrations -t 60
Replaces #925