Raise forbidden error if un authenticated users load email api. #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouseknecht
suggested changes
Feb 13, 2019
galaxy/api/views/email.py
Outdated
| class UserEmailList(base_views.SubListAPIView): | ||
| model = EmailAddress | ||
| serializer_class = serializers.EmailSerializer | ||
| parent_model = User | ||
| relationship = 'emailaddress_set' | ||
|
|
||
| def get_queryset(self): | ||
| deny_anonymous_users(self.request.user) |
There was a problem hiding this comment.
I think this should be handled in access.py
There was a problem hiding this comment.
Definitely get_queryset() is not the best place for checking user permissions.
Please use permission_classes = (IsAuthenticated,)
cutwater
requested changes
Feb 13, 2019
galaxy/api/views/email.py
Outdated
| class UserEmailList(base_views.SubListAPIView): | ||
| model = EmailAddress | ||
| serializer_class = serializers.EmailSerializer | ||
| parent_model = User | ||
| relationship = 'emailaddress_set' | ||
|
|
||
| def get_queryset(self): | ||
| deny_anonymous_users(self.request.user) |
There was a problem hiding this comment.
Definitely get_queryset() is not the best place for checking user permissions.
Please use permission_classes = (IsAuthenticated,)
cutwater
approved these changes
Feb 14, 2019
newswangerd
added a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1522