1694 lint errors #1695
Merged
1694 lint errors #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gundalow
added
the
test
|
build error is a false positive: |
|
|
decentral1se
approved these changes
Jan 24, 2019
Closed
|
Triggering Travis rerun as we've merged a few other Test update PRs. |
webknjaz
reviewed
Jan 24, 2019
webknjaz
reviewed
Jan 24, 2019
themr0c
force-pushed
the
1694-lint-errors
branch
from
bdf6ccb
to
961acd5
Compare
|
Good news on the latest build the lint errors are fixed https://travis-ci.com/ansible/molecule/builds/98832571 (and we will probably get all failures that are already present in master). |
|
As pointed out before, we end up with a conflict between the format checker and the linter: lint gets green but format-checker fails https://travis-ci.com/ansible/molecule/jobs/173464580 |
webknjaz
reviewed
Jan 29, 2019
tox.ini
Outdated
| [testenv:format-check] | ||
| commands = | ||
| yapf -d -r molecule/ test/ | ||
|
|
||
| deps = yapf>=0.25.0,<2 |
There was a problem hiding this comment.
AFAIR the syntax for reusing is deps = {[format]deps}. Plz check...
There was a problem hiding this comment.
I don't understand?
There was a problem hiding this comment.
i eventually understood !
done
webknjaz
reviewed
Jan 29, 2019
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
…grade flake8 to 3.6.0, make sure the versions of the packages are defined only in one single place. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
… binary operator, as latest version of yapf is in conflict with this rule, see google/yapf#658. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
…37}-lint', so cleanup the tox.ini Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Co-Authored-By: themr0c <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
themr0c
force-pushed
the
1694-lint-errors
branch
from
9006653
to
da427d9
Compare
webknjaz
reviewed
Jan 30, 2019
pilou-
approved these changes
Jan 30, 2019
singuliere
approved these changes
Jan 30, 2019
|
Merged, thank you everybody for the reviews! |
ssbarnea
pushed a commit
to ssbarnea/molecule
that referenced
this pull request
Jan 31, 2019
* 1694 lint errors Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * fixes ansible#1694, reimplement ansible#1574 - fix linting issues, upgrade flake8 to 3.6.0, make sure the versions of the packages are defined only in one single place. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * fix ansible#1694 lint errors - excluding rule [W504] line break after binary operator, as latest version of yapf is in conflict with this rule, see google/yapf#658. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * fix ansible#1694 lint errors - travis is using 'lint', not 'py{27,36,37}-lint', so cleanup the tox.ini Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * remove file commited by error Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * Update tox.ini Co-Authored-By: themr0c <themr0c@users.noreply.github.com> * reuse deps and extras Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabrice Flore-Thebault themr0c@users.noreply.github.com
fix #1694 lint errors
some modifications to tox.ini so the lint tasks don't depend on all dependencies unused for the lint task.
PR Type