-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on sh library #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
rm/sh
branch
2 times, most recently
from
October 27, 2020 14:21
f6acc7d
to
8882673
Compare
ssbarnea
changed the title
WIP: Remove use of sh library
Remove dependency on sh library
Oct 27, 2020
I like the simplicity of |
ssbarnea
requested review from
geerlingguy,
cloudnull,
felixfontein,
a user and
odyssey4me
October 27, 2020 15:03
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-podman
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-vagrant
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-vagrant
that referenced
this pull request
Oct 28, 2020
ssbarnea
added a commit
to ansible-community/molecule-vagrant
that referenced
this pull request
Oct 28, 2020
👏 👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh
library withsubprocess-tee
while adopting a loose-coupling approach, so we do not rely on implementation details of the subprocess library.molecule.util.run_command
or thebake()
.Fixed: #2678
Related: amoffat/sh#450 amoffat/sh#512