CIA-270: Refactor Commands #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if create_instances and not idempotent: | ||
| self.create() | ||
| Create(self.args, self.molecule).execute() |
There was a problem hiding this comment.
Not a blocker, just my 2 cents:
You used this pattern in a lot of places, but I prefer to see that split in 2 lines, one for creating the object, one for calling the function.
|
I like it! Way clearer/simpler! 👍 |
|
@rgreinho No problem, I updated to break those all out into multiple lines. |
|
+1 Yeah, deff a good cleanup. |
identifystation
pushed a commit
that referenced
this pull request
Jan 7, 2016
CIA-270: Refactor Commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a huge change, but it's mostly moving code around and removing duplication. I was unable to use Remy's DocOpt pattern mentioned in #76 due to an unresolved DocOpt bug. However this work makes it very easy to switch to his pattern at a later time.