Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨Only use setuptools-scm-git-archive under < py37 #502

Conversation

webknjaz
Copy link
Member

setuptools-scm supports Git archives natively starting v7 but it only supports Python 3.7 or higher. This patch makes up a set of conditional build dependencies that add setuptools-scm-git-archive only below Python 3.7 and in combination with an older version of setuptools-scm.

ISSUE TYPE
  • Bugfix Pull Request
  • Maintenance Pull Request
  • Packaging Pull Request
ADDITIONAL INFORMATION

N/A

@webknjaz webknjaz self-assigned this May 11, 2023
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch 5 times, most recently from bea1b83 to 439fc6c Compare May 14, 2023 00:20
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 439fc6c to b2e5ecd Compare July 11, 2023 16:47
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from b2e5ecd to fba91ea Compare November 7, 2023 14:39
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from fba91ea to 3295a7c Compare January 17, 2024 15:50
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-502
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 334de3d to bc37f87 Compare January 17, 2024 16:10
@Qalthos Qalthos force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from bc37f87 to 659f62e Compare January 17, 2024 20:50
`setuptools-scm` support Git archives natively starting v7 but it only
supports Python 3.7 or higher. This patch makes up a set of
conditional build dependencies that add `setuptools-scm-git-archive`
only below Python 3.7 and in combination with an older version of
`setuptools-scm`.
webknjaz added a commit to webknjaz/pylibssh that referenced this pull request Jan 18, 2024
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 659f62e to 5af665a Compare January 18, 2024 14:03
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 18, 2024
webknjaz added a commit to webknjaz/pylibssh that referenced this pull request Jan 18, 2024
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 5af665a to 4fce9b2 Compare January 18, 2024 14:06
webknjaz added a commit to webknjaz/pylibssh that referenced this pull request Jan 18, 2024
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 4fce9b2 to 9fda730 Compare January 18, 2024 14:10
@webknjaz webknjaz force-pushed the maintenance/pep517-setuptools-scm-git-archive-split branch from 9fda730 to 1136191 Compare January 18, 2024 14:27
@webknjaz
Copy link
Member Author

FTR the centos stream 8 job in CI took 49m 24s, instead of the usual ~2min. Looks like there's currently some network issues. Not sure if it's within the GitHub platform or on the distro infra side.

@webknjaz webknjaz merged commit fd8b20a into ansible:devel Jan 18, 2024
170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants