Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get TLS working again in TCP backend #112

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Get TLS working again in TCP backend #112

merged 2 commits into from
Aug 25, 2020

Conversation

ghjm
Copy link
Contributor

@ghjm ghjm commented Aug 25, 2020

At some point in the rewrites of the TCP listener, TLS got dropped. This puts it back, and also fixes a bug where the TCP backend dialer timeout was much too short.

@ghjm ghjm requested a review from squidboylan August 25, 2020 16:45
@squidboylan
Copy link
Contributor

in logs when i run this locally with my updated SSL tests i see:

ERROR 2020/08/25 09:56:36 Backend receiving error tls: first record does not look like a TLS handshake
ERROR 2020/08/25 09:56:36 Backend sending error tls: first record does not look like a TLS handshake

and

ERROR 2020/08/25 09:55:48 Backend receiving error tls: unsupported SSLv2 handshake received
ERROR 2020/08/25 09:55:48 Backend sending error tls: unsupported SSLv2 handshake received

when connecting to a tls server from a client without a tls cert, i expect that's what's breaking ci as well

@ghjm ghjm merged commit 8383491 into ansible:devel Aug 25, 2020
@ghjm ghjm deleted the fix_tls branch August 25, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants