Services logger #730
Merged
Services logger #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AaronH88
force-pushed
the
services_logger
branch
from
5d48369
to
e8d41f3
Compare
AaronH88
force-pushed
the
services_logger
branch
3 times, most recently
from
2c1568a
to
6489b07
Compare
shanemcd
reviewed
Feb 10, 2023
AaronH88
force-pushed
the
services_logger
branch
from
6489b07
to
cf68730
Compare
shanemcd
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on PR #723 , this PR follows the same logging methodology and extends it to the services package.
Based off of Shanes PR here: #718
and the blog here: https://gogoapps.io/blog/passing-loggers-in-go-golang-logging-best-practices/#global-state
Once PR #723 is merged, I will rebase this PR and take it out of draft.