Add unit tests and mocks to stdio_utils and rework workceptor tests to use table driven testing #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronH88
force-pushed
the
stdis_utils_tests
branch
3 times, most recently
from
ccec2e5
to
f2f0b1b
Compare
AaronH88
force-pushed
the
stdis_utils_tests
branch
4 times, most recently
from
d029421
to
2188c43
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
…o use table driven testing
AaronH88
force-pushed
the
stdis_utils_tests
branch
from
2188c43
to
21d7953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created interfaces and a wrapper for os and io functionality.
Mocked os and io functionality so that no file is created or read during testing.
Exposed the constructor for
NewStdinReaderandNewStdinWriter,Created
Setmethods for the reader and writer to create injection points for our mocks.Refactored the rest of the codebase to use the exported constructor and os/io wrapper (
FileSystem).