Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for packetconn #833

Merged
merged 14 commits into from
Sep 13, 2023
Merged

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Aug 31, 2023

Add unit tests for packetconn
Add interface NetcForPacketConn

@matoval matoval marked this pull request as ready for review September 5, 2023 18:27
@AaronH88
Copy link
Contributor

AaronH88 commented Sep 6, 2023

Where is sonarcloud? 😮

@AaronH88
Copy link
Contributor

Sonar cloud has found 3 code smells for you to address, once that is done we should be good to rebase and merge 😄

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 9b707e6 into ansible:devel Sep 13, 2023
15 checks passed
AaronH88 pushed a commit to AaronH88/receptor that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants