Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websockets unit tests and wrap gorilla library #892

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

AaronH88
Copy link
Contributor

@AaronH88 AaronH88 commented Nov 1, 2023

No description provided.

Co-authored-by: matoval <msandova@redhat.com>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #892 (f1360fa) into devel (8a8cee2) will increase coverage by 0.93%.
The diff coverage is 44.00%.

@@            Coverage Diff             @@
##            devel     #892      +/-   ##
==========================================
+ Coverage   32.40%   33.34%   +0.93%     
==========================================
  Files          40       40              
  Lines        7360     7390      +30     
==========================================
+ Hits         2385     2464      +79     
+ Misses       4841     4786      -55     
- Partials      134      140       +6     
Files Coverage Δ
pkg/backends/websockets.go 52.91% <44.00%> (+24.23%) ⬆️

... and 3 files with indirect coverage changes

@AaronH88 AaronH88 marked this pull request as ready for review November 7, 2023 17:35
Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
6.6% 6.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AaronH88 AaronH88 merged commit e2c1090 into ansible:devel Nov 8, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants