Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load certificate test and support non-standard Go versions in make #982

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 39.94%. Comparing base (5bc3119) to head (4f64eb6).

@@            Coverage Diff             @@
##            devel     #982      +/-   ##
==========================================
+ Coverage   39.60%   39.94%   +0.33%     
==========================================
  Files          42       42              
  Lines        6615     6617       +2     
==========================================
+ Hits         2620     2643      +23     
+ Misses       3795     3772      -23     
- Partials      200      202       +2     
Files Coverage Δ
pkg/certificates/cli.go 4.86% <0.00%> (ø)
pkg/certificates/ca.go 28.06% <44.44%> (+7.74%) ⬆️

... and 3 files with indirect coverage changes

Makefile Show resolved Hide resolved
@thom-at-redhat thom-at-redhat changed the title Add load certificate test Add load certificate test and support non-standard Go versions in make Apr 2, 2024
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 97685d2 into ansible:devel Apr 2, 2024
17 checks passed
@thom-at-redhat thom-at-redhat deleted the add_load_certificate_test branch April 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants