Avoid full dep install prior to tox run #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hille721 Mind having a look? |
* Set XDG_CACHE_HOME * Delete settings.json * Fomatting fix * Empty environ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix for type env --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Gonna push this one in so it can be tested. Will report back. |
|
Looks good for this commit: https://github.com/ansible-collections/ansible.scm/actions/runs/5812294815/job/15757373073?pr=227 10s savings, (17s vs 7s) |
I'm not using the gh action so far as I'm in my companies own Gitlab. But in the Gitlab CI there I also just install tox-ansible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the base python interpreter, only tox and tox-ansible should be needed since the collection specific deps will be installed per environment by the plugin.
This should save some set-up time and the full dep list is not needed in the base.