Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible-creator integration with extension #1000

Merged
merged 24 commits into from
Nov 6, 2023
Merged

Ansible-creator integration with extension #1000

merged 24 commits into from
Nov 6, 2023

Conversation

priyamsahoo
Copy link
Contributor

The PR adds ansible-creator integrated in a webview with 'init' capability.
Resolves: #977.

@priyamsahoo
set up commands and menu items for ansible content-creator
e183be0
@priyamsahoo
update command runner to remove colors in execution of command
95eb92f
@priyamsahoo
add welcome page for ansible content-creator
b9e09ee
@priyamsahoo
add init page for ansible content-creator
b27ed06
@priyamsahoo
add interface for ansible-creator init options
9924788
@priyamsahoo
change refresh button type
dbd51b7
@priyamsahoo
add feature to open folder selection dialog and abilty to open scaffo…
e6d2150 
…lded collection in the workspace
@priyamsahoo
add webpack config for the ansible-creator webviews
6e1e789
@priyamsahoo
update class name
9aa06f4
@priyamsahoo
re-organize extension.ts code
fa368c8
@priyamsahoo
update dependencies and welcome message for ansible-creator
a31e661
@priyamsahoo
Merge branch 'main' into webview
84d7a78
@priyamsahoo
add codicon source files
65d0673
@priyamsahoo
add react as dev dependency to resolve peer dependency issue for webv…
e913a52 
…iew-ui-toolkit
@priyamsahoo priyamsahoo added the feature New feature or request label Oct 26, 2023
@priyamsahoo priyamsahoo temporarily deployed to ack October 26, 2023 16:10 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 26, 2023 16:10 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 26, 2023 16:12 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 26, 2023 16:43 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 26, 2023 16:43 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 26, 2023 17:11 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 26, 2023 17:12 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 26, 2023 17:26 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 26, 2023 17:27 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 11:02 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 30, 2023 11:02 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 11:04 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 30, 2023 11:05 Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 11:33 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 11:44 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 11:54 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 30, 2023 15:44 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo temporarily deployed to ack October 31, 2023 03:20 — with GitHub Actions Inactive
@priyamsahoo priyamsahoo marked this pull request as ready for review October 31, 2023 12:00
@priyamsahoo priyamsahoo requested a review from a team as a code owner October 31, 2023 12:00
cidrblock
cidrblock approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY, will need other reviews as well

ssbarnea
ssbarnea approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect to wait for @ganeshrn review on this.

As a note, you are lucky that we do not have code coverage measured on this project, as I do not see any tests included. ;)

@ssbarnea ssbarnea merged commit de7b804 into ansible:main Nov 6, 2023
7 checks passed
@priyamsahoo priyamsahoo mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
feature New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration of ansible-creator in the extension
4 participants
@priyamsahoo @ssbarnea @ganeshrn @cidrblock