Fix unbound_dot: allow requests without domain parameter set

plugins/module_utils/main/unbound_dot.py

@@ -39,7 +39,8 @@ def __init__(self, module: AnsibleModule, result: dict, session: Session = None)
         self.dot = {}
 
     def check(self) -> None:
-        validate_domain(module=self.m, domain=self.p['domain'])
+        if not is_unset(self.p['domain']):
+            validate_domain(module=self.m, domain=self.p['domain'])
         validate_port(module=self.m, port=self.p['port'])
 
         if not is_unset(self.p['verify']) and \
@@ -50,7 +51,11 @@ def check(self) -> None:
                 f"nor a valid hostname!"
             )
 
-        self.b.find(match_fields=['domain', 'target'])
+        if is_unset(self.p['domain']):
+            self.b.find(match_fields=['target'])
+
+        else:
+            self.b.find(match_fields=['domain', 'target'])
 
         if self.p['state'] == 'present':
             self.r['diff']['after'] = self.b.build_diff(data=self.p)

tests/cleanup.yml

@@ -64,13 +64,14 @@
 
     - name: Cleanup Unbound DNS-over-TLS
       ansibleguy.opnsense.unbound_dot:
-        domain: "{{ item.d }}"
-        target: "{{ item.t }}"
+        target: "{{ item }}"
         state: 'absent'
         reload: false  # speed
       loop:
-        - {d: 'dot.opnsense.test.ansibleguy.net', t: '1.1.1.1'}
-        - {d: 'dot.opnsense.test.ansibleguy.net', t: '1.1.1.2'}
+        - '1.1.1.1'
+        - '1.1.1.2'
+        - '1.1.1.3'
+        - '1.1.1.4'
 
     - name: Cleanup Unbound DNS-Forwarding's
       ansibleguy.opnsense.unbound_forward:

tests/unbound_dot.yml

@@ -127,15 +127,54 @@
         opn3.data | length != 1
       when: not ansible_check_mode
 
+    - name: Adding 3 without domain
+      ansibleguy.opnsense.unbound_dot:
+        target: '1.1.1.3'
+        verify: 'dot.opnsense.test.ansibleguy.net'
+        reload: false  # speed
+      register: opn6
+      failed_when: >
+        opn6.failed or
+        not opn6.changed
+
+    - name: Changing 3 port
+      ansibleguy.opnsense.unbound_dot:
+        target: '1.1.1.3'
+        verify: 'dot.opnsense.test.ansibleguy.net'
+        port: 853
+        reload: false  # speed
+      register: opn6
+      failed_when: >
+        opn6.failed or
+        not opn6.changed
+
+    - name: Removing 3
+      ansibleguy.opnsense.unbound_dot:
+        target: '1.1.1.3'
+        verify: 'dot.opnsense.test.ansibleguy.net'
+        state: 'absent'
+        reload: false
+      when: not ansible_check_mode
+
+    - name: Adding 4 without domain or verify
+      ansibleguy.opnsense.unbound_dot:
+        target: '1.1.1.4'
+        reload: false  # speed
+      register: opn7
+      failed_when: >
+        opn7.failed or
+        not opn7.changed
+
     - name: Cleanup
       ansibleguy.opnsense.unbound_dot:
-        domain: "{{ item.d }}"
-        target: "{{ item.t }}"
+        target: "{{ item }}"
         state: 'absent'
         reload: false
       loop:
-        - {d: 'dot.opnsense.test.ansibleguy.net', t: '1.1.1.1'}
-        - {d: 'dot.opnsense.test.ansibleguy.net', t: '1.1.1.2'}
+        - '1.1.1.1'
+        - '1.1.1.2'
+        - '1.1.1.3'
+        - '1.1.1.4'
       when: not ansible_check_mode
 
     - name: Listing dots