Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render field names as names rather than literals so that they're escaped when necessary #258

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

dmgd
Copy link
Contributor

@dmgd dmgd commented Aug 12, 2023

While playing around with Kotshi (which is very nice!) I noticed I couldn't generate an adapter for one class, because it had a field name that it probably shouldn't, in.

Copy link
Owner

@ansman ansman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, looks like an oversight that a literal was used in the first place. Thanks!

@ansman ansman enabled auto-merge (squash) August 12, 2023 10:01
@ansman ansman merged commit 5f38a22 into ansman:main Aug 12, 2023
4 checks passed
@ansman
Copy link
Owner

ansman commented Aug 14, 2023

This was just released in 2.13.1

@dmgd dmgd deleted the escape-field-rendering branch August 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants