Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove non needed inputs #519

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Jul 12, 2024

Duplicate of #517 to use a branch name passing CI.


Thanks @dipinknair for noticing that some inputs in the private actions were not needed.

This comes from the fact that two steps are performed before running any private action (checkout and setup-python) Since both private actions (windows and linux) are not involved in python setup and git install + clone, this PR removes the following inputs from the private actions:

  • python-version
  • use-python-cache
  • checkout

When gathering common steps into doc-build,
some inputs were not removed from the private actions.
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner July 12, 2024 06:54
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Jul 12, 2024
@SMoraisAnsys SMoraisAnsys changed the title REFACTOR: Remove non needed inputs refactor: remove non needed inputs Jul 12, 2024
@SMoraisAnsys SMoraisAnsys merged commit 089e4ba into main Jul 13, 2024
26 of 27 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/doc-build-not-needed-inputs branch July 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants