Refactor object3d #142
Merged
Refactor object3d #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
# Conflicts: # _unittest/test_Primitives.py # pyaedt/modeler/Primitives.py
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
# Conflicts: # _unittest/ignore_test_Icepak.py # _unittest/test_08_Primitives.py
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
- set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class
# Conflicts: # pyaedt/hfss.py
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
- experimental refactor to propose to help with testing Design.py - added DesignCache object to identify new error messages and changes in design - intended for increasing scrutiny of unit-testing All Application Classes - set AlwaysNew=True, release_on_exit=True as default when accessing Desktop from within a Design Object API Docs - Added Object3D classes to the docs Object3d.py - Major refactoring of Object3d class! - added setter and getters for all properties, removed som set_ and get_functions - docstring work (ongoing) - property color - return tuple of int instead of string, add color_string property for consistency - added odesign property - added rgb codes - created unit tests Modeler.py - minor modifications to reflect changes to Object3d class Primitives.py - refactor draw_polyline to create_polyline - add properties solids, sheets, lines and object_names. - add _refresh_object_types function to update the above properties - remove update_object_properties since implemented in Object3d now - minor modifications to reflect changes to Object3d class Primitives3D.py - minor modifications to reflect changes to Object3d class Primitives2D.py - minor modifications to reflect changes to Object3d class Unit Testing - Started renaming tests to enforce the order frim simple to complex - Added test_07_Object3D.py - added class BasisTest and wrappers pyaedt_unittest_same_design, pyaedt_unittest_same_design, pyaedt_unittest_same_design - refactored test_08_Primitives.py and test_01_Design.py to use the above structures
maxcapodi78
requested changes
Jun 23, 2021
pyaedt/hfss.py
Outdated
Comment on lines
252
to
253
| :class: BoundaryObject | ||
| Boundary object |
There was a problem hiding this comment.
Please revert to original review docstrings. This way is not working with PyCharm
| Returns | ||
| ------- | ||
|
|
||
| """ |
There was a problem hiding this comment.
why did you deleted the docstrings for this method?
There was a problem hiding this comment.
I refactored this function to a protected _refresh_all_ids_from_aedt_file and thus do not need the docstring anymore
Co-authored-by: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com>
…_Object3d # Conflicts: # _unittest/conftest.py
maxcapodi78
approved these changes
Jun 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design.py
All Application Classes
API Docs
Object3d.py
Modeler.py
Primitives.py
Primitives3D.py
Primitives2D.py
Unit Testing