Refactor of Primitives Classes to Return Object3d objects #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General Refactoring of consequences and debugging
Added new object operations to Object3d.py
…sections of polylines/equation-based curves
added solid_names, sheet_names and line_names, as well as liine_objects, sheet_objects and solid_object properties to Primitives
# Conflicts: # pyaedt/application/Analysis3D.py # pyaedt/modeler/Object3d.py # pyaedt/modeler/Primitives.py
Moved older AEDTLib examples into AEDTLib_archive
Updated unit test on Section in Object3d
…m/pyansys/PyAEDT into Create_Primitives_Returns_Objects # Conflicts: # pyaedt/modeler/Object3d.py
…m/pyansys/PyAEDT into Create_Primitives_Returns_Objects # Conflicts: # pyaedt/modeler/Object3d.py
|
@maxcapodi78 I need your help regarding the 4 failing unit tests. Thx |
yes, we can work on that tomorrow |
I think we need to slightly modify the pipeline to skip ironphyton folder |
…s' into Create_Primitives_Returns_Objects
Fixed waveport test
…m/pyansys/PyAEDT into Create_Primitives_Returns_Objects
Fixed waveport test
…m/pyansys/PyAEDT into Create_Primitives_Returns_Objects
…m/pyansys/PyAEDT into Create_Primitives_Returns_Objects
# Conflicts: # pyaedt/modeler/Primitives.py
maxcapodi78
approved these changes
Jul 14, 2021
|
Great to get this one done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the way we manage geometric primitives in the modeler. All create_xxx functions of the Primitives modules return objects rather than ids. This may break some existing applications. All examples in our suite have been adjusted.
We also introduce unit-testing from IronPython using unittest. This is a preliminary implementation and will be extended in the near future.