Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in edb net plot. #3630

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fixed error in edb net plot. #3630

merged 1 commit into from
Sep 26, 2023

Conversation

Alberto-DM
Copy link
Contributor

Fixed an error in edb.net plot function which was preventing the correct axis scale of the plot. Now the plot is automatically scaled based on the board dimensions.
Also the x and y axis of the plot were scaled differently and this resulted in plots that were out of proportion. This has been fixed too.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alberto-DM Alberto-DM enabled auto-merge (squash) September 26, 2023 12:39
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3630 (72051da) into main (5eb3fc5) will increase coverage by 49.49%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #3630       +/-   ##
===========================================
+ Coverage   31.40%   80.90%   +49.49%     
===========================================
  Files         178      178               
  Lines       61384    61401       +17     
===========================================
+ Hits        19276    49674    +30398     
+ Misses      42108    11727    -30381     

@maxcapodi78 maxcapodi78 merged commit cbe1f79 into main Sep 26, 2023
12 checks passed
@maxcapodi78 maxcapodi78 deleted the bugfix_edb_net_plot branch September 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants