Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create port enhancement #3813

Merged
merged 16 commits into from
Oct 31, 2023
Merged

create port enhancement #3813

merged 16 commits into from
Oct 31, 2023

Conversation

hui-zhou-a
Copy link
Contributor 

        U7 = edbapp.components["U7"]
        U7.pins["G7"].create_port()
        port = U7.pins["F7"].create_port(reference=U7.pins["E7"])
        port.is_circuit_port = True
        _, pin_group = edbapp.siwave.create_pin_group_on_net(
            reference_designator="U7", net_name="GND", group_name="U7_GND"
                                              )
        U7.pins["F7"].create_port(reference=pin_group)

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Oct 27, 2023 that may be closed by this pull request
EDB API : Possibility to create a circuit port from aedt pin name... #3704
Closed
@github-actions github-actions bot added the edb label Oct 27, 2023
@hui-zhou-a
Copy link
Contributor Author

@SMoraisAnsys this is edb related.

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #3813 (824e850) into main (95f50e4) will increase coverage by 0.00%.
The diff coverage is 91.22%.

@@           Coverage Diff           @@
##             main    #3813   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files         180      180           
  Lines       62257    62297   +40     
=======================================
+ Hits        50504    50539   +35     
- Misses      11753    11758    +5

PipKat
PipKat reviewed Oct 27, 2023
View reviewed changes
pyaedt/edb.py Show resolved Hide resolved
PipKat
PipKat reviewed Oct 27, 2023
View reviewed changes
pyaedt/edb.py Outdated Show resolved Hide resolved
hui-zhou-a and others added 8 commits October 27, 2023 16:28
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/terminals.py
22e9f22 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/sources.py
a8c6af5 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/sources.py
27c87f1 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/padstacks_data.py
994acf6 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/padstacks_data.py
6d838fa 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a @PipKat
Update pyaedt/edb.py
cd62bd8 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
fix
7c04952
@hui-zhou-a @PipKat
Update pyaedt/edb_core/edb_data/padstacks_data.py
eac312a 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@SMoraisAnsys SMoraisAnsys mentioned this pull request Oct 31, 2023
Closed
18 tasks
@hui-zhou-a hui-zhou-a merged commit 83f6157 into main Oct 31, 2023
12 checks passed
@hui-zhou-a hui-zhou-a deleted the create_port_on_padstack branch October 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDB API : Possibility to create a circuit port from aedt pin name...
3 participants
@hui-zhou-a @svandenb-dev @PipKat