Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padstack name #3814

Closed
wants to merge 6 commits into from
Closed

padstack name #3814

wants to merge 6 commits into from

Conversation

hui-zhou-a
Copy link
Contributor

@maxcapodi78 @svandenb-dev there is a change in the padstack name. It may break customer code, but I think it is better to correct the way how the padstack name is returned in the lone run.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Oct 27, 2023 that may be closed by this pull request
@github-actions github-actions bot added the edb label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3814 (b80ce85) into main (95f50e4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3814      +/-   ##
==========================================
- Coverage   81.12%   81.11%   -0.01%     
==========================================
  Files         180      180              
  Lines       62257    62254       -3     
==========================================
- Hits        50504    50498       -6     
- Misses      11753    11756       +3     

@svandenb-dev
Copy link
Collaborator

@maxcapodi78 @svandenb-dev there is a change in the padstack name. It may break customer code, but I think it is better to correct the way how the padstack name is returned in the lone run.

I am not sure sure we can change the pin naming (e.g component.pin name). This will for sure break current flows. I remember we had to sync EDB pin name with AEDT ones. @maxcapodi78 what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants