Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siwave SYZ bug fix and refactor #3840

Merged
merged 67 commits into from
Nov 8, 2023
Merged

Siwave SYZ bug fix and refactor #3840

merged 67 commits into from
Nov 8, 2023

Conversation

hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Nov 2, 2023

@svandenb-dev @maxcapodi78 @SMoraisAnsys this refactor is a preparation for below features. Some freq sweep related bugs are fixed too.

  • corrected default setting values for SIwave SYZ and DCIR.
  • set_dc_slider, set_si_slider, set_pi_slider methods set all related attributes corresponding to accuracy level.
class BaseSimulationSetup(object):
    """Ansys.Ansoft.SimSetupData.Data.BaseSimulationSettings."""

    def __init__(self, pedb, edb_setup=None):
        self._pedb = pedb

        self._setup_type_mapping = {
            "kHFSS": self._pedb.simsetupdata.HFSSSimulationSettings,
            "kPEM": None,
            "kSIwave": self._pedb.simsetupdata.SIwave.SIWSimulationSettings,
            "kLNA": None,
            "kTransient": None,
            "kQEye": None,
            "kVEye": None,
            "kAMI": None,
            "kAnalysisOption": None,
            "kSIwaveDCIR": self._pedb.simsetupdata.SIwave.SIWDCIRSimulationSettings,
            "kSIwaveEMI": None,
            "kHFSSPI": None,
            "kDDRwizard": None,
            "kQ3D": None,
            "kNumSetupTypes": None,
        }

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #3840 (76614e9) into main (876744c) will increase coverage by 0.04%.
Report is 7 commits behind head on main.
The diff coverage is 90.64%.

❗ Current head 76614e9 differs from pull request most recent head bd8e2c7. Consider uploading reports for the commit bd8e2c7 to get more accurate results

@@            Coverage Diff             @@
##             main    #3840      +/-   ##
==========================================
+ Coverage   81.11%   81.15%   +0.04%     
==========================================
  Files         180      181       +1     
  Lines       62281    62382     +101     
==========================================
+ Hits        50520    50629     +109     
+ Misses      11761    11753       -8     

hui-zhou-a and others added 22 commits November 6, 2023 21:14
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hui-zhou-a hui-zhou-a enabled auto-merge (squash) November 8, 2023 08:20
@hui-zhou-a hui-zhou-a merged commit bd026c9 into main Nov 8, 2023
11 checks passed
@hui-zhou-a hui-zhou-a deleted the freq_sweep_bug_fix branch November 8, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Compute Exact DC Point" functionality to siwave SYZ sweep
4 participants