Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create port on pin enhancement #3858

Merged
merged 30 commits into from
Nov 10, 2023
Merged

Conversation

svandenb-dev
Copy link
Collaborator

Port name option added to overwrite default naming convention

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Nov 9, 2023
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 9, 2023 08:48
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #3858 (07d50af) into main (7b692a2) will decrease coverage by 0.01%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
- Coverage   31.45%   31.45%   -0.01%     
==========================================
  Files         182      182              
  Lines       62677    62681       +4     
==========================================
  Hits        19715    19715              
- Misses      42962    42966       +4     

@Samuelopez-ansys Samuelopez-ansys merged commit 7c9af4b into main Nov 10, 2023
11 of 12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the create_port_on_pin_enhancement branch November 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding option to provide port name with method create_port_on_component to overwrite default naming
4 participants