Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix refresh padsatck def after layer name changed #3939

Merged

Conversation

svandenb-dev
Copy link
Collaborator

Update layer for padstack definition when layer.name setter is used.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Dec 4, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the edb label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #3939 (e9cf9fe) into main (44ae3d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
+ Coverage   81.32%   81.33%   +0.01%     
==========================================
  Files         182      182              
  Lines       63070    63107      +37     
==========================================
+ Hits        51290    51331      +41     
+ Misses      11780    11776       -4     

…er_layer_name_changed' into bug_fix_refresh_padsatck_def_after_layer_name_changed
Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 3376ce9 into main Dec 5, 2023
12 checks passed
@svandenb-dev svandenb-dev deleted the bug_fix_refresh_padsatck_def_after_layer_name_changed branch December 5, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in EDB padstack definitions when layer names are changed
3 participants