-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix refresh padsatck def after layer name changed #3939
Merged
svandenb-dev
merged 36 commits into
main
from
bug_fix_refresh_padsatck_def_after_layer_name_changed
Dec 5, 2023
Merged
Bug fix refresh padsatck def after layer name changed #3939
svandenb-dev
merged 36 commits into
main
from
bug_fix_refresh_padsatck_def_after_layer_name_changed
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyaedt/edb_core/edb_data/primitives_data.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
2 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3939 +/- ##
==========================================
+ Coverage 81.32% 81.33% +0.01%
==========================================
Files 182 182
Lines 63070 63107 +37
==========================================
+ Hits 51290 51331 +41
+ Misses 11780 11776 -4 |
18 tasks
…er_layer_name_changed' into bug_fix_refresh_padsatck_def_after_layer_name_changed
PipKat
reviewed
Dec 4, 2023
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
hui-zhou-a
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
svandenb-dev
deleted the
bug_fix_refresh_padsatck_def_after_layer_name_changed
branch
December 5, 2023 13:53
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update layer for padstack definition when layer.name setter is used.