Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix merge nets polygon #3950

Merged
merged 39 commits into from
Dec 7, 2023
Merged

Bug fix merge nets polygon #3950

merged 39 commits into from
Dec 7, 2023

Conversation

svandenb-dev
Copy link
Collaborator

Bug fix see related issue linked.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #3950 (7871089) into main (2811961) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3950      +/-   ##
==========================================
- Coverage   81.35%   81.35%   -0.01%     
==========================================
  Files         182      182              
  Lines       63183    63130      -53     
==========================================
- Hits        51405    51358      -47     
+ Misses      11778    11772       -6     

pyaedt/edb_core/layout.py Outdated Show resolved Hide resolved
pyaedt/edb_core/layout.py Outdated Show resolved Hide resolved
pyaedt/edb_core/nets.py Outdated Show resolved Hide resolved
svandenb-dev and others added 4 commits December 7, 2023 08:32
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@svandenb-dev svandenb-dev merged commit 325cc63 into main Dec 7, 2023
11 of 12 checks passed
@svandenb-dev svandenb-dev deleted the bug_fix_merge_nets_polygon branch December 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when merging two nets (edb.core_nets.merge_nets_polygons) on multi-layer PCB
3 participants