Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding padstackinstance terminal position getter #3977

Merged
merged 35 commits into from
Dec 14, 2023

Conversation

svandenb-dev
Copy link
Collaborator

Padstack instance terminal position getter added

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3977 (f16ed38) into main (3664c1b) will increase coverage by 0.02%.
Report is 15 commits behind head on main.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
+ Coverage   81.36%   81.38%   +0.02%     
==========================================
  Files         182      182              
  Lines       63179    63166      -13     
==========================================
+ Hits        51405    51408       +3     
+ Misses      11774    11758      -16     

@svandenb-dev svandenb-dev added enhancement New features or code improvements edb labels Dec 14, 2023
@svandenb-dev svandenb-dev merged commit ec96bdb into main Dec 14, 2023
11 of 12 checks passed
@svandenb-dev svandenb-dev deleted the adding_padstackinstance_terminal_position_getter branch December 14, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PadstackinstanceTerminal getter missing
3 participants