Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of aedt logger #4025

Merged
merged 10 commits into from
Jan 11, 2024
Merged

Refactoring of aedt logger #4025

merged 10 commits into from
Jan 11, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

# Conflicts:
#	pyaedt/modules/SolveSetup.py
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (6fa6ddf) 81.63% compared to head (446d854) 81.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
+ Coverage   81.63%   81.74%   +0.10%     
==========================================
  Files         182      182              
  Lines       63546    63631      +85     
==========================================
+ Hits        51876    52013     +137     
+ Misses      11670    11618      -52     

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dcrawforAtAnsys dcrawforAtAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 5135995 into main Jan 11, 2024
13 of 15 checks passed
@maxcapodi78 maxcapodi78 deleted the improve_logger_messages branch January 11, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants