Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipc exporter false error issue #4043

Merged
merged 39 commits into from
Jan 10, 2024
Merged

Conversation

svandenb-dev
Copy link
Collaborator

Fixing false error messages when padstack definitions are not defined

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev added bug Something isn't working edb labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@47b0ff9). Click here to learn what that means.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4043   +/-   ##
=======================================
  Coverage        ?   81.44%           
=======================================
  Files           ?      182           
  Lines           ?    63571           
  Branches        ?        0           
=======================================
  Hits            ?    51774           
  Misses          ?    11797           
  Partials        ?        0           

@svandenb-dev svandenb-dev enabled auto-merge (squash) January 9, 2024 12:49
Copy link
Collaborator

@ring630 ring630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 6fa6ddf into main Jan 10, 2024
14 checks passed
@svandenb-dev svandenb-dev deleted the ipc_exporter_false_error_issue branch January 10, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPC 2581 exporter throws false errors when dummy padstack defintions are presents.
2 participants