-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create port on pin name selection adjustment #4061
Create port on pin name selection adjustment #4061
Conversation
# Conflicts: # pyaedt/edb_core/edb_data/primitives_data.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
===========================================
- Coverage 81.64% 31.20% -50.45%
===========================================
Files 182 182
Lines 63537 63639 +102
===========================================
- Hits 51876 19858 -32018
- Misses 11661 43781 +32120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixing pin selection in component.create_port_on_pin() for instance pin A1 and A15 can be wrongly both selected.