Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create port on pin name selection adjustment #4061

Merged
merged 40 commits into from
Jan 12, 2024

Conversation

svandenb-dev
Copy link
Collaborator

Fixing pin selection in component.create_port_on_pin() for instance pin A1 and A15 can be wrongly both selected.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) January 11, 2024 13:22
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c1de513) 81.64% compared to head (a57218b) 31.20%.
Report is 9 commits behind head on main.

❗ Current head a57218b differs from pull request most recent head f086937. Consider uploading reports for the commit f086937 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4061       +/-   ##
===========================================
- Coverage   81.64%   31.20%   -50.45%     
===========================================
  Files         182      182               
  Lines       63537    63639      +102     
===========================================
- Hits        51876    19858    -32018     
- Misses      11661    43781    +32120     

@svandenb-dev svandenb-dev added bug Something isn't working edb labels Jan 11, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@svandenb-dev svandenb-dev merged commit ab3443b into main Jan 12, 2024
13 of 14 checks passed
@svandenb-dev svandenb-dev deleted the create_port_on_pin_name_selection_adjustmnet branch January 12, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component.create_port_on_pin() pin selection criteria can meet wrong pins
3 participants